Skip to content

Use netlink instead of Wireless Extensions #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Caellian wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Use netlink instead of Wireless Extensions #1879

Caellian wants to merge 17 commits into from

Conversation

@Caellian
Copy link
Collaborator

@Caellian Caellian commented May 1, 2024 •
edited
Loading

This PR removes deprecated iwlib related code and replaces it with netlink library.

State

  • change/setup dependencies
    • update CI & Docker files
  • implement some basic code that can handle some of the existing stats
    • dispatch new requests when requests aren't in_flight already
  • simplify changes for future contributors
    • improve documentation
  • reduce diff

Testing

  • nl cache works
  • test commands
    • wireless_ap
    • wireless_bitrate
    • wireless_channel
    • wireless_essid
    • wireless_freq
    • wireless_link_qual
    • wireless_link_qual_max
    • wireless_mode
  • test default command values
  • ensure correct interface data is returned
  • ensure correct network info is returned
  • check delay between command issuing and finish callback to determine ideal handling (eager vs. lazy)
  • test what happens when conky only renders once

@Caellian Caellian linked an issue May 1, 2024 that may be closed by this pull request
Migrate from libiw to libnl for wireless support #1001
Open
@github-actions github-actions bot added sources PR modifies project sources dependencies adds or removes dependencies, or suggests alternatives networking related to network information reporting labels May 1, 2024
@netlify
Copy link

netlify bot commented May 1, 2024 •
edited
Loading

✅ Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 46aeafb
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/67004ef22181d20008621958

@brndnmtthws brndnmtthws added the feature suggest addition of new functionality that isn't currently supported in any way label May 1, 2024
@github-actions github-actions bot added 3rdparty suggests changes to 3rd party dependencies gh-actions suggest changing GitHub actions build system related to build system (CMake) and/or building process/assumptions labels May 1, 2024
@Caellian Caellian force-pushed the dev/netlink branch 12 times, most recently from eb4a7a3 to 1e09e69 Compare May 1, 2024 19:24
Caellian
Caellian commented May 2, 2024
View reviewed changes
@github-actions github-actions bot added the os: macos related to MacOS label May 2, 2024
@Caellian Caellian force-pushed the dev/netlink branch 4 times, most recently from 26d73c2 to 494942a Compare May 3, 2024 12:00
@Caellian
Copy link
Collaborator Author

Caellian commented May 5, 2024 •
edited
Loading

Ok, got interface information to update, so this PR is ~70% done with regards to figuring stuff out:

image

@Caellian Caellian mentioned this pull request May 9, 2024
Closed
@Caellian Caellian mentioned this pull request Jul 15, 2024
Closed
@Caellian Caellian mentioned this pull request Oct 3, 2024
Open
@github-actions github-actions bot added the display: x11 related to X11 backend label Oct 4, 2024
@Caellian Caellian mentioned this pull request Oct 19, 2024
Closed
@Caellian Caellian linked an issue Dec 17, 2024 that may be closed by this pull request
[Bug]: ${addrs} now reports gateway's address instead of machine address. #1542
Open
Caellian added 16 commits May 6, 2025 05:49
@Caellian
Start implementing netlink
57195f6 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Add nl80211 header
d3a2b06 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Add CI dependencies and fix build issues
189880d 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Copy iw info implementation
f0cdf9b 
Update linux headers

Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Add genl dependency to CI
a914e8a 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Move new code to netlink-conky
1076e71 
Replace define with a wrapper struct.

Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Improve API
6088562 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Start implementing tasks
974ed32 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Add required nl80211 callbacks
65c95b6 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Add argument forwarding to nl_task
7bac550 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Add dependencies to Dockerfile
039da07 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Cleanup nested_attributes helper
5b8fb02 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Fix runtime errors
fe9e540 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Get interface information to work
5e9b48d 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Switch to promises for callback results
a21240f 
Signed-off-by: Tin Švagelj <[email protected]>
@Caellian
Fix compile errors
ab07649 
Signed-off-by: Tin Švagelj <[email protected]>
@github-actions github-actions bot added the os: linux related exclusively to Linux (not BSD/MacOS) label May 6, 2025
@netlify
Copy link

netlify bot commented May 6, 2025 •
edited
Loading

✅ Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit a88c6f8
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/681988a8074c220008d68b96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3rdparty suggests changes to 3rd party dependencies build system related to build system (CMake) and/or building process/assumptions dependencies adds or removes dependencies, or suggests alternatives display: x11 related to X11 backend feature suggest addition of new functionality that isn't currently supported in any way gh-actions suggest changing GitHub actions networking related to network information reporting os: linux related exclusively to Linux (not BSD/MacOS) os: macos related to MacOS sources PR modifies project sources

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: ${addrs} now reports gateway's address instead of machine address. Migrate from libiw to libnl for wireless support

3 participants

@Caellian @brndnmtthws