fix: percent_print respects use_spacer when pad_percents is unset#2330
Open
riteshdhurwey wants to merge 1 commit intobrndnmtthws:mainfrom
Open
fix: percent_print respects use_spacer when pad_percents is unset#2330riteshdhurwey wants to merge 1 commit intobrndnmtthws:mainfrom
riteshdhurwey wants to merge 1 commit intobrndnmtthws:mainfrom
Conversation
When pad_percents is 0 (default), use a width of 3 so that use_spacer = 'left' and 'right' work correctly for percentage values like cpu, battery, etc. Fixes brndnmtthws#2078
✅ Deploy Preview for conkyweb canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
use_spacer = 'left'was ignored for${cpu}and other percentagevalues when
pad_percentswas not explicitly set.Root Cause
percent_print()passedpad_percents(default: 0) as width tospaced_print(). A width of 0 means no padding, so spacer had no effect.Fix
Default width to 3 when
pad_percentsis unset, since percentagevalues are always 1-3 digits (0-100).
Testing
Tested on Arch Linux with
use_spacer = 'left':Before:
CPU: 5%CPU: 14%(inconsistent width)After:
CPU: 5%CPU: 14%(consistent width)Closes #2078