Skip to content

M2 cnv updates 1534#40

Open
yueyaog wants to merge 26 commits intomasterfrom
m2_cnv_updates_1534
Open

M2 cnv updates 1534#40
yueyaog wants to merge 26 commits intomasterfrom
m2_cnv_updates_1534

Conversation

@yueyaog
Copy link
Collaborator

@yueyaog yueyaog commented Aug 9, 2023

I migrated the modifications made by @MicahR-Y in TAG PR 1534 to this PR. I have structured this PR to exclusively present the differences between the official GATK workflows and the TAG workflows.

The incorporation of these changes will lead to the removal of certain approved modifications (those are small changes). Here are the essential changes that should be incorporated: #17 #19 #26

docker: tag_docker
memory: machine_mem + " MB"
disks: "local-disk " + select_first([disk_space, 10]) + " HDD"
preemptible: select_first([preemptible_attempts, 10])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the preempt(i/a)ble default to 3 instead of 10

Boolean? compress_vcfs
File? gga_vcf
File? gga_vcf_idx
String? gcs_project_for_requester_pays
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this input. We want to localize those input before running GATK tools

echo "$passing_INDEL" > passing_indel.txt

#filtered only INDELs
bcftools isec -C -O v -o ${basename}.indel.filtered.vcf -w1 ${basename}.indel.vcf.gz ${basename}.indel.passing.vcf.gz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yueyaog I think the issue in this task at least is these ${basename} instead of ~{basename}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants