Open
Conversation
MicahR-Y
requested changes
Jul 30, 2024
Collaborator
MicahR-Y
left a comment
MicahR-Y
left a comment
There was a problem hiding this comment.
@yueyaog I made some suggestions for this code. The two major points are changing the inputs to an array to allow for more than 2 samples to be cross-checked at once and including an option for not failing the workflow if the samples don't match.
| String output_name | ||
| String picard_docker = "us.gcr.io/broad-gotc-prod/genomes-in-the-cloud:2.4.1-1540490856" | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| Int mismatch_rc = if fail_on_mismatch then 1 else 2 |
|
|
||
| workflow CrosscheckFingerprintsWorkflow { | ||
| input { | ||
| File input_bamA |
Collaborator
There was a problem hiding this comment.
Suggested change
| File input_bamA |
| workflow CrosscheckFingerprintsWorkflow { | ||
| input { | ||
| File input_bamA | ||
| File input_bamB |
Collaborator
There was a problem hiding this comment.
Suggested change
| File input_bamB | |
| Array[File] input_bams |
| File input_bamB | ||
| File hapmap | ||
| File reference_fasta | ||
| String output_name |
Collaborator
There was a problem hiding this comment.
Suggested change
| String output_name | |
| String output_name | |
| Boolean fail_on_mismatch = false |
|
|
||
| call CrosscheckFingerprints { | ||
| input: | ||
| input_bamA = input_bamA, |
Collaborator
There was a problem hiding this comment.
Suggested change
| input_bamA = input_bamA, |
| I=~{input_bamB} \ | ||
| HAPLOTYPE_MAP=~{hapmap} \ | ||
| CROSSCHECK_BY=SAMPLE \ | ||
| O=~{output_name}.crosscheck_metrics \ |
Collaborator
There was a problem hiding this comment.
Suggested change
| O=~{output_name}.crosscheck_metrics \ | |
| O=~{output_name}.crosscheck_metrics.txt \ |
| HAPLOTYPE_MAP=~{hapmap} \ | ||
| CROSSCHECK_BY=SAMPLE \ | ||
| O=~{output_name}.crosscheck_metrics \ | ||
| REFERENCE_SEQUENCE=~{reference} \ |
Collaborator
There was a problem hiding this comment.
Suggested change
| REFERENCE_SEQUENCE=~{reference} \ | |
| REFERENCE_SEQUENCE=~{reference} \ | |
| EXIT_CODE_WHEN_MISMATCH=~{mismatch_rc} \ | |
| ~{extra_args} \ |
| } | ||
|
|
||
| output { | ||
| File crosscheckmetrics = "~{output_name}.crosscheck_metrics" |
Collaborator
There was a problem hiding this comment.
Suggested change
| File crosscheckmetrics = "~{output_name}.crosscheck_metrics" | |
| File crosscheckmetrics = "~{output_name}.crosscheck_metrics.txt" | |
| String crosscheck_results = if read_int("rc") == 0 then "PASS" else "FAIL" |
| File crosscheckmetrics = "~{output_name}.crosscheck_metrics" | ||
| } | ||
| } | ||
| # |
Collaborator
There was a problem hiding this comment.
Can you remove the commented out task here?
| output_name = output_name, | ||
| picard_docker = picard_docker | ||
| } | ||
| # call FingerprintsResult { |
Collaborator
There was a problem hiding this comment.
Can you remove the commented out call here?
MicahR-Y
reviewed
Sep 16, 2024
|
|
||
| runtime { | ||
| docker: picard_docker | ||
| disks: "local-disk " + disk_gb + " HDD" |
Collaborator
There was a problem hiding this comment.
Suggested change
| disks: "local-disk " + disk_gb + " HDD" | |
| disks: "local-disk " + disk_gb + " HDD" | |
| continueOnReturnCode: [0, 2] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@MicahR-Y Here is the original crosscheck FP WDL. Feel free to suggest changes or send me the updated version you have.