Skip to content

Cramtobam WDL Update#62

Open
Patrick-Schlaeger-Broad wants to merge 14 commits intomasterfrom
cramtobam_update_ps
Open

Cramtobam WDL Update#62
Patrick-Schlaeger-Broad wants to merge 14 commits intomasterfrom
cramtobam_update_ps

Conversation

@Patrick-Schlaeger-Broad

Added an updated CramToBam folder, including a CramToBam WDL along with a README.md with instructions and example for use. The CramToBam WDL was updated from an old WDL made in 2017, which is now bugged. This is fixed in the updated version.

@Patrick-Schlaeger-Broad Patrick-Schlaeger-Broad changed the title Cramtobam Update Cramtobam WDL Update Jul 25, 2024
Copy link
Collaborator

@yueyaog yueyaog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code improvement. Minor changes are needed.

@yueyaog
Copy link
Collaborator

yueyaog commented Aug 5, 2024

Could you add this to dockstore by adding an entry in dockstore.yml file? @Patrick-Schlaeger-Broad

Added CramToBam to Dockstore
@Patrick-Schlaeger-Broad
Copy link
Author

Could you add this to dockstore by adding an entry in dockstore.yml file? @Patrick-Schlaeger-Broad

Completed! The only issue is that I don't have a test.json file for the testParameterFiles input. I just deleted that section for now, but I don't know if I will need to add one or not for it to show up correctly on Dockstore. @yueyaog

@yueyaog
Copy link
Collaborator

yueyaog commented Aug 5, 2024

Could you add this to dockstore by adding an entry in dockstore.yml file? @Patrick-Schlaeger-Broad

Completed! The only issue is that I don't have a test.json file for the testParameterFiles input. I just deleted that section for now, but I don't know if I will need to add one or not for it to show up correctly on Dockstore. @yueyaog

You could generate it using womtools. Can you add one using womtools input?

@Patrick-Schlaeger-Broad
Copy link
Author

Could you add this to dockstore by adding an entry in dockstore.yml file? @Patrick-Schlaeger-Broad

Completed! The only issue is that I don't have a test.json file for the testParameterFiles input. I just deleted that section for now, but I don't know if I will need to add one or not for it to show up correctly on Dockstore. @yueyaog

You could generate it using womtools. Can you add one using womtools input?

I added in a womtools input.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants