adding function for mode="nmf"#67
Open
anupriyatripathi wants to merge 3 commits intobroadinstitute:masterfrom
Open
adding function for mode="nmf"#67anupriyatripathi wants to merge 3 commits intobroadinstitute:masterfrom
anupriyatripathi wants to merge 3 commits intobroadinstitute:masterfrom
Conversation
tangram/mapping_utils.py
Outdated
| cluster_label (String): field in `adata.obs` used for aggregating values | ||
| nmf_coeffs (pd.DataFrame): NMF `H` matrix (factor by sample) | ||
| sample_name (String): name of the sample to be mapped as labeled in `nmf_coeffs` | ||
| scale (bool): Optional. Whether weight input single cell by # of cells in cluster. Default is True. |
| ) | ||
| if mode == "nmf": | ||
| adata_sc = adata_to_nmf_factor_expression( | ||
| adata_sc, cluster_label, nmf_coeffs, sample_name, add_density=True |
There was a problem hiding this comment.
Does it make sense to assume that you have an "adata_sc"? For NMF mapping, you're just starting with nmf_factors and nmf_coeffs. I would recommend passing both of those, and building the adata in the new function.
Author
There was a problem hiding this comment.
One usually runs tg.pp_adatas() before tg.map_cells_to_space() (which calls adata_to_nmf_factor_expression()). So, I think we can assume that we have adata_sc. Is that what you were wondering about?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
option 1i.e. mapping NMF W*H on spatial data.@hejinhuang could you please review it?