Ignore sites with null GTs during de novo rate calculation#810
Open
epiercehoffman wants to merge 3 commits intomainfrom
Open
Ignore sites with null GTs during de novo rate calculation#810epiercehoffman wants to merge 3 commits intomainfrom
epiercehoffman wants to merge 3 commits intomainfrom
Conversation
Collaborator
Author
|
Updated to also discard null genotypes prior to per-sample benchmarking. Re-tested and verified that the de novo rate is the only thing that differs between this branch and the main branch. The following MainVcfQc plots were identical:
Also verified that the sample VID lists are only used in per-sample QC, per-family QC, and per-sample benchmarking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
The intention of analyze_fams.R is to exclude sites for which any member of the trio has a null genotype (line 120). However, CollectVidsPerSample excludes null genotypes from each sample's carrier VID list (line 105). Those genotypes therefore appear as NA for that sample in analyze_fams.R when merged with another trio member who is a carrier, and they are treated thereafter as hom ref (line 133). This is not the intention of the script, and creates ambiguity in the de novo rate, as there is no claim made about the genotype when it is null.
This PR retains the VIDs with null genotypes for each sample so those sites can be discarded for the entire trio as intended during the de novo rate calculation. The null genotypes are removed prior to per-sample QC to maintain the previous behavior. The impact of null genotypes on the de novo rate should be examined further and reported as described in #807.
Testing