Skip to content

Fix activity startup race condition #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brodeurlv merged 1 commit into from
Jan 15, 2026
Merged

Fix activity startup race condition #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/src/main/java/com/easyfitness/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,7 @@ public boolean onOptionsItemSelected(@NonNull MenuItem item) {
}

mIntro014Launched = false; // redisplay the intro
savePreferences(); // saving immediatly to prevent a race condition with another instance of this activity

dialog.dismiss(); // Close the dialog
finish(); // Close app
Expand Down Expand Up @@ -846,6 +847,9 @@ private void showFragment(String pFragmentName) {
@Override
protected void onStop() {
super.onStop();

//This shouldn't be relied on. When this condition is finishing another activity can read the preferences before this saves the final state.
//TODO search and remove code that still relies on this saving the preferences
savePreferences();
}

Expand Down