Open
Conversation
But keep the bones so I don't have to reinvent the build end of things.
[x] The tokenizing works so far. [x] Basic printing is working, but all tests aren't passing. [x] Useful tests are passing, unspecified ones aren't. So everything mentioned in step 1 is done, the deferable (and otherwise unspecified) ones aren't. It'll do.
Not all tests are passing but crucially a valid AST is produced!
Relatively painless apart from the rather obtuse error: error: expecting a top level declaration Which was the result of having calls to `repl_env.set(...)` in the file. Moving it to `apply` fixed it, not sure why having statements at file level isn't kosher, maybe a JVM hangover?
Now all but the deferable stuff works! The non–deferable stuff is a little fragile (lots of assumptions about types) but the happy path is happy enough for me!
Trickiest part was figuring out why the test was hanging: because the code kept hitting StackOverflow error :/
Fixed the inevitable bug involving newlines not being handled correctly during tokenization. Mostly puzzled at eval failing when calling (do ...) as calling EVAL meant the final form would be evaluated again instead of returned. Still haven't quite figured out why that happens but meh tests are passing.
cons & concat are working, so far so good quote now implemented
Reimplementing quasiquote AIUI, the recommended approach was … confusing.
Implement unquote Also fix string repr so tests pass
The lazy hack to treat vectors like lists hit its limit with the deferrable tests.
The previous implementation was clunky, now both act like callable things.
After it compiled the non–deferrable tests passed off the bat. Pleasantly surprised.
Initial impl was _very_ lazy.
And the related functions.
Now most of the tests pass! A minor bug with the `cond` macro where the evaluator goes into an infinite loop when there's no valid condition. Meh.
Passes the basic tests, start to trip up on intentional misuses of functions as their failure modes weren't specified.
If Kotlin had currying map could be even cleaner.
Luckily Kotlin's world view lines up closely with mal.
This seems the appropriate point to implement meta.
It makes the code much more pleasing to look at.
Misc tweaks as I dawdle before finishing.
Not sure why I went with the initial rubbish solution, probably because late night coding does not a good result make.
And format mal code for sanity.
Something I thought was a macro bug turned out to bug in else-less if which I'd never tried in anger.
Not sure why I didn't do this before.
They're getting a little unwieldy now but it'll do.
It seems self-hosting from step 4 requires number? so I implemented the rest while I was there. First time (maybe?) that _all_ the tests are passing for a step!
Could've done this a while back just didn't think to!
What is expected and what is documented is a little hard to follow and so the code became. Now it's clearer what's needed so is the code.
Now passes step 1 tests.
Trying to get all the tests passing now. Fortunately this is just a matter of updating interfaces and evalling structures proper.
Similar to step 2 fixes but also tweaked fail message to make tests pass.
Also hadn't quite implemented a couple of things properly so had to fix those for most tests to pass.
With this fix step 4 finally passes. Having the host language share effectively the same escaping mechanism got confusing for a while there.
Bumps [debug](https://github.com/visionmedia/debug) from 2.6.1 to 3.2.6. - [Release notes](https://github.com/visionmedia/debug/releases) - [Commits](debug-js/debug@2.6.1...3.2.6) Signed-off-by: dependabot[bot] <support@github.com>
Author
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps debug from 2.6.1 to 3.2.6.
Release notes
Sourced from debug's releases.
Commits
a7a17c93.2.6f312a89fix: performance issue9a6d8c23.2.5cc5f146fix browserify and supply alternative unpkg entry point (closes #606)78741cc3.2.4700a010re-introduce node.js (root file) (ref #603)622e5793.2.284e41d53.2.1b3f8f8euse babel-ified distributed source for browsersdec4b153.2.0Maintainer changes
This version was pushed to npm by qix, a new releaser for debug since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.