Add interface assignments to API #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browningluke
requested changes
Aug 7, 2025
Owner
browningluke
left a comment
browningluke
left a comment
There was a problem hiding this comment.
Hey @black3x3, thanks for making this PR too! I just approved and merged your other one into the opnsense-go repo.
Before we get this one merged too, can you please add some documentation for the interfaces_vip and interfaces_assign resources. Check under docs/ for some examples of what's been done for the existing resources.
I see you've already added a resource example which is great, but can you also add one for the assign resource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have worked on this Issue as I also need this functionality. Additionally, I have opened pull requests in the following repositories:
- opnsense/core#8436
- browningluke/opnsense-go#25
I would appreciate a review and would be happy to improve the quality of the changes.