Allow "any" direction for firewall filter rules#92
Open
politician wants to merge 1 commit intobrowningluke:mainfrom
Open
Allow "any" direction for firewall filter rules#92politician wants to merge 1 commit intobrowningluke:mainfrom
politician wants to merge 1 commit intobrowningluke:mainfrom
Conversation
Add "any" as a valid direction value in the firewall filter rule schema (both v1 and v0) and add acceptance test covering create, import, and update with the new direction value. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
browningluke
approved these changes
Feb 18, 2026
Owner
browningluke
left a comment
There was a problem hiding this comment.
LGTM, thanks for this @politician!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The UI let users choose
Bothdirections for firewall rules covering bothinandout, this wasn't supported in the provider, this PR fixes it.Note: I wasn't sure if I had to update the v0 schema, I did it though.
Note 2: I used Claude to write the tests
Type of Change
Testing
Describe how you tested your changes:
Examples
examples/directoryEnvironment
Checklist
make docs)make fmt)