Conversation
|
I don't know of any of us are capable of reviewing this particular PR for you... 😎 |
|
@blerner Fixed the issues you pointed out. |
|
Curious what the addition of the two comment lines (the only change) to |
|
@ds26gte that's because I had a separate repo where I was pushing all this code: https://github.com/rachitnigam/pyret-lang.vim Keeping it in a separate repo helps with vim plugin managers that can directly update the plugin. I didn't think this repo would want that repo as a submoodule so I moved the latest code here. |
|
Ah. Sounds good. And since you seem to be way more versed in VimL than I, please do feel free to improve |
|
I've had this on for a week now. Is there any reason it could cause searching to become SLOW? Like 10-20 seconds lag when I press enter after a search like |
|
I haven't noticed a slowdown compared to JS Files of similar sizes. It's pretty lightweight for a syntax highlughter (most of it is just color coding keywords) |
|
I still see extreme slowdowns with this in terminal vim on OSX with iterm2, bad enough that I can't navigate around files over a few 100s of lines reasonably. Interestingly, the same doesn't happen in GUI mode Macvim. |
|
That's curious. I haven't had problems with the newest neovim and vim versions either. |
From the heretical lands where the church of emacs does not exist, I bring to you, VIM: