Draft
Conversation
- Extra arg removed for BigInteger.prototype.{round,roundEven,tan,atan,cos,sin,expt,acos,asin}
- bnpExp() should take errbacks arg and use it if exponent too large
- bnModPowInt() should take errbacks arg and pass it along to bnpExp()
- bnPow() should take errbacks arg and pass it along to bnpExp()
…rownplt#1799. In fact, it doesn't give up at all, because any argument that doesn't blow memory necessarily has a tractable logarithm.
…cos,tan} brownplt#1799 - num-{acos,asin,atan} don't have opportunity to trigger errbacks in method, so incorrectness (since corrected) was benign - num-{exp,expt} now show proper error (previous error was incorrect convergence, didn't even trigger errbacks) - num-log now always converges for convergent input (errbacks correctly propagated now, but impossible to trigger)
- test-numbers: use Racket value for log of large number in check block
…that can't be tested via Pyret
- improve fromString() to use itself recursively rather than makeBignum()
…ecursive fromString() calls
fromFixnum(): fix for when argument fixnum is less than about 1e-7, brownplt/code.pyret.org#556
js-numbers.js: log() for nonintegral rational arguments = log(numr) - log(denr)
Member
|
I don't understand this PR -- it sounds like @shriram asked for design changes on the previous one, so either we should work on that, or we should close it. I don't understand the implementation here -- there's no mention of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update of @ess476's PR #1217 that added
mapandfiltermethods to sets.The previous PR is 7 years old and needed to be updated to mesh with the current
horizon.This PR is a working placeholder that we should use a basis to design how we want to proceed with this.