Skip to content

Remove process.exit() Usage #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fine-ai wants to merge 1 commit into from
Closed

Remove process.exit() Usage #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,18 @@ process.on('SIGTERM', shutdown);

function shutdown() {
console.log('SIGTERM signal received: closing HTTP server');
server.close();
process.exit(0);
server.close(() => {
console.log('HTTP server closed');

// Set exit code instead of calling exit directly
process.exitCode = 0;
});

// Add timeout to force exit if graceful shutdown takes too long
setTimeout(() => {
console.log('Forcing shutdown after timeout');
process.exit(1);
}, 10000).unref();
}

server.listen({
Expand Down