(very) simple bug fix for screenshot method #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unpack the input options as the base playwright screenshot method accepts keyword arguments only
options might be None.
|
Hey @guyvandam ! Thanks for the contrib, we're just making sure we fix the issues in CI before merging 🙏 💯 |
filip-michalsky
approved these changes
Jun 23, 2025
|
@guyvandam thanks a lot for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unpack the input options as the base playwright
screenshotmethod accepts keyword arguments onlywhy
can't use the
screenshotfunction bc of this bug when on local envwhat changed
simple unpacking for arguments to comply to base playwright
screenshotmethod that accepts keyword arguments onlyhttps://github.com/microsoft/playwright-python/blob/0ff7fc983ef39ed6121ffbac4eaf15e9b02a6aba/playwright/async_api/_generated.py#L2768
test plan
regular (?)