fix api key example in README #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original config uses model_api_key, not client_options https://github.com/browserbase/stagehand-python/blob/main/stagehand/config.py#L22
miguelg719
reviewed
Jul 3, 2025
| project_id=os.getenv("BROWSERBASE_PROJECT_ID"), | ||
| model_name="google/gemini-2.5-flash-preview-05-20", | ||
| model_client_options={"apiKey": os.getenv("MODEL_API_KEY")}, | ||
| model_api_key=os.getenv("MODEL_API_KEY"), |
miguelg719
approved these changes
Jul 5, 2025
|
Thanks for the contrib @friparia ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
config
model_client_optionsis not in config.py, this configuration not workinghttps://github.com/browserbase/stagehand-python/blob/main/stagehand/config.py#L22
what changed
change this config to model_api_key
test plan