Skip to content

Patch issue with passing a created session_id to init on api mode #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025
Merged

Patch issue with passing a created session_id to init on api mode #168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8c3b14
Patch issue with passing a created session_id to init on api mode
miguelg719 Jul 25, 2025
45ed5dc
changeset
miguelg719 Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stagehand/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ async def _create_session(self):
"modelName": self.model_name,
"verbose": 2 if self.verbose == 3 else self.verbose,
"domSettleTimeoutMs": self.dom_settle_timeout_ms,
"browserbaseSessionID": self.session_id,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if a session exists, it resumes it, correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's right, this fixes

"browserbaseSessionCreateParams": (
browserbase_session_create_params
if browserbase_session_create_params
Expand Down
10 changes: 1 addition & 9 deletions stagehand/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,15 +399,7 @@ async def init(self):
if self.env == "BROWSERBASE":
# Create session if we don't have one
if self.use_api:
if not self.session_id:
await self._create_session() # Uses self._client and api_url
self.logger.debug(
f"Created new Browserbase session via Stagehand server: {self.session_id}"
)
else:
self.logger.debug(
f"Using existing Browserbase session: {self.session_id}"
)
await self._create_session() # Uses self._client and api_url

# Connect to remote browser
try:
Expand Down