Skip to content

Conversation

@shrey150
Copy link
Contributor

@shrey150 shrey150 commented Nov 20, 2025

Why

The current implementation has issues with asyncio test loops and the ExtractResult return value in the extract handler. Additionally, there are inconsistencies in accessing page properties and test failures in the act integration tests.

What Changed

  • Added asyncio test loop configuration in pytest.ini to use session scope for better performance
  • Fixed ExtractResult return value in extract_handler.py to return the full result object
  • Removed redundant event_loop fixture from conftest.py as it's now handled by pytest.ini settings
  • Updated page property access in tests from stagehand.page to stagehand._page to match implementation
  • Fixed act integration test by updating the selector text and properly accessing extract result data
  • Fixed assertions in tests to correctly access the page_text property in extraction results

Test Plan

Run the existing test suite to verify that:

  1. Asyncio tests run correctly with the new session-scoped event loop
  2. Extract handler returns the correct result format
  3. All tests pass with the updated page property access pattern
  4. Act integration tests correctly interact with dropdown elements

GitHub: Closes #

@shrey150 shrey150 mentioned this pull request Nov 20, 2025
Copy link
Contributor Author

shrey150 commented Nov 20, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shrey150 shrey150 force-pushed the shreypandya/bump-litellm-version branch from 38f1bee to 1b87812 Compare November 20, 2025 23:27
@shrey150 shrey150 force-pushed the 11-20-fix_broken_tests branch 2 times, most recently from 641d2cc to bca4530 Compare November 24, 2025 19:58
@shrey150 shrey150 changed the base branch from shreypandya/bump-litellm-version to graphite-base/237 December 3, 2025 01:28
@shrey150 shrey150 force-pushed the 11-20-fix_broken_tests branch from bca4530 to 5484140 Compare December 3, 2025 01:28
@shrey150 shrey150 changed the base branch from graphite-base/237 to main December 3, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants