abstract functionality and fix default_schema #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STG-469 Abstract browser and api functionality from client
Also fixing default schema issue on local (passing JSON doesn't work on litellm, schemas must be pydantic) |
…tionality-from-client
miguelg719
commented
Jun 2, 2025
miguelg719
commented
Jun 2, 2025
miguelg719
commented
Jun 2, 2025
miguelg719
commented
Jun 3, 2025
| self.logger.info("Getting accessibility tree data") | ||
| output_string = tree["simplified"] | ||
| id_to_url_mapping = tree.get("idToUrl", {}) | ||
| self.logger.info(f"schema: {schema}") |
miguelg719
commented
Jun 3, 2025
filip-michalsky
approved these changes
Jun 3, 2025
Collaborator
filip-michalsky
left a comment
filip-michalsky
left a comment
There was a problem hiding this comment.
lgtm - merging to my examples branch now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
what changed
test plan