Skip to content

Update default extensions to match node #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Update default extensions to match node #145

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59c4cd8
Update default extensions to match node
TehShrike Jan 4, 2018
a578a0f
Update default extensions to match node
TehShrike Jan 4, 2018
dff99ad
Merge branch 'master' into default-extensions
TehShrike Sep 11, 2018
410df04
Tests for resolving json/node extensions by default
TehShrike Sep 11, 2018
740da15
Merge branch 'default-extensions' of github.com:TehShrike/resolve int…
TehShrike Sep 11, 2018
0b80213
Sync tests for non-default extensions
TehShrike Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module.exports = function resolve(x, options, callback) {
};
var readFile = opts.readFile || fs.readFile;

var extensions = opts.extensions || ['.js'];
var extensions = opts.extensions || ['.js', '.json', '.node'];
var y = opts.basedir || path.dirname(caller());

opts.paths = opts.paths || [];
Expand Down
2 changes: 1 addition & 1 deletion lib/sync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module.exports = function (x, options) {
};
var readFileSync = opts.readFileSync || fs.readFileSync;

var extensions = opts.extensions || ['.js'];
var extensions = opts.extensions || ['.js', '.json', '.node'];
var y = opts.basedir || path.dirname(caller());

opts.paths = opts.paths || [];
Expand Down
4 changes: 2 additions & 2 deletions readme.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ default `opts` values:
{
paths: [],
basedir: __dirname,
extensions: [ '.js' ],
extensions: [ '.js', '.json', '.node' ],
readFile: fs.readFile,
isFile: function (file, cb) {
fs.stat(file, function (err, stat) {
Expand Down Expand Up @@ -132,7 +132,7 @@ default `opts` values:
{
paths: [],
basedir: __dirname,
extensions: [ '.js' ],
extensions: [ '.js', '.json', '.node' ],
readFileSync: fs.readFileSync,
isFile: function (file) {
try { return fs.statSync(file).isFile() }
Expand Down