Skip to content

fix: autocomplete enhancement fixes #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: autocomplete enhancement fixes #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/rules/autocomplete-a11y-matches.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,14 @@ function quantityField(node) {
});
}

function isReadOnly(node) {
return node.hasAttribute('readonly');
}

function isCombobox(node) {
return node.getAttribute('role') === 'combobox';
}

function autocompleteA11yMatches(node, virtualNode) {
const a11yEngineFlag = true;
/* the flag is used to tell autocomplete matcher that it is being called
Expand All @@ -100,7 +108,9 @@ function autocompleteA11yMatches(node, virtualNode) {
return (
autocompleteMatches(node, virtualNode, a11yEngineFlag) &&
!nodeIsASearchFunctionality(node) &&
!quantityField(node)
!quantityField(node) &&
!isReadOnly(node) &&
!isCombobox(node)
);
}

Expand Down
Loading