-
Notifications
You must be signed in to change notification settings - Fork 2
chore: release 5.6.1-at modal detecting utils #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rohitsahu-bstack
wants to merge
5
commits into
main
Choose a base branch
from
AXE-2039-modal-at-enhancment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e8d0368
modal detecting utils
rohitsahu-bstack ac98ca4
Apply suggestion from @Copilot
rohitsahu-bstack 35b0aba
:robot: Automated formatting fixes
rohitsahu-bstack 824733a
Apply suggestion from @Copilot
rohitsahu-bstack 10c2713
copilot comments
rohitsahu-bstack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
import { getViewportSize } from '../../commons/dom'; | ||
export default function detectModalStack(options) { | ||
options = options || {}; | ||
const modalPercent = options.modalPercent || 0.75; | ||
|
||
// there is no "definitive" way to code a modal so detecting when one is open | ||
// is a bit of a guess. a modal won't always be accessible, so we can't rely | ||
// on the `role` attribute, and relying on a class name as a convention is | ||
// unreliable. we also cannot rely on the body/html not scrolling. | ||
// | ||
// because of this, we will look for two different types of modals: | ||
// "definitely a modal" and "could be a modal." | ||
// | ||
// "definitely a modal" is any visible element that is coded to be a modal | ||
// by using one of the following criteria: | ||
// | ||
// - has the attribute `role=dialog` | ||
// - has the attribute `aria-modal=true` | ||
// - is the dialog element | ||
// | ||
// "could be a modal" is a visible element that takes up more than 75% of | ||
// the screen (though typically full width/height) and is the top-most element | ||
// in the viewport. since we aren't sure if it is or is not a modal this is | ||
// just our best guess of being one based on convention. | ||
|
||
// if (cache.get('isModalOpen')) { | ||
// return cache.get('isModalOpen'); | ||
// } | ||
|
||
const definiteModals = Array.from( | ||
document.querySelectorAll( | ||
'dialog[open], [role="dialog"], [role="alertdialog"], [aria-modal="true"]' | ||
) | ||
); | ||
|
||
// to find a "could be a modal" we will take the element stack from each of | ||
// four corners and one from the middle of the viewport (total of 5). if each | ||
// stack contains an element whose width/height is >= 75% of the screen, we | ||
// found a "could be a modal" | ||
const viewport = getViewportSize(window); | ||
const percentWidth = viewport.width * modalPercent; | ||
const percentHeight = viewport.height * modalPercent; | ||
const x = (viewport.width - percentWidth) / 2; | ||
const y = (viewport.height - percentHeight) / 2; | ||
|
||
const points = [ | ||
// top-left corner | ||
{ x, y }, | ||
// top-right corner | ||
{ x: viewport.width - x, y }, | ||
// center | ||
{ x: viewport.width / 2, y: viewport.height / 2 }, | ||
// bottom-left corner | ||
{ x, y: viewport.height - y }, | ||
// bottom-right corner | ||
{ x: viewport.width - x, y: viewport.height - y } | ||
]; | ||
|
||
const stacks = points.map(point => { | ||
return Array.from(document.elementsFromPoint(point.x, point.y)); | ||
}); | ||
|
||
return { definiteModals, stacks }; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import { getViewportSize } from '../../commons/dom'; | ||
|
||
export default function getOverlayFromStack(elm, options) { | ||
options = options || {}; | ||
const modalPercent = options.modalPercent || 0.75; | ||
|
||
const viewport = getViewportSize(window); | ||
const percentWidth = viewport.width * modalPercent; | ||
const percentHeight = viewport.height * modalPercent; | ||
|
||
if (elm instanceof window.Element) { | ||
const style = window.getComputedStyle(elm); | ||
if ( | ||
parseInt(style?.width, 10) >= percentWidth && | ||
parseInt(style?.height, 10) >= percentHeight && | ||
style?.getPropertyValue('pointer-events') !== 'none' && | ||
(style?.position === 'absolute' || style?.position === 'fixed') | ||
) { | ||
rohitsahu-bstack marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return true; | ||
} | ||
} | ||
return false; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.