-
Notifications
You must be signed in to change notification settings - Fork 2
fix: AXE-2194 - FR1 fix false positives #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds text comparison functionality to fix false positives in the label content name mismatch check, specifically for AXE-2194 FR1. The changes implement advanced text comparison using stemming and cosine similarity to better match visible text with accessible names.
- Adds stemming-based text comparison with synonym handling and unicode normalization
- Introduces inline overflow checking to skip hidden elements in text calculation
- Enhances text processing options to include whitespace removal
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
package.json | Adds wink-porter2-stemmer dependency for text stemming functionality |
lib/commons/text/subtree-text.js | Adds overflow detection to skip hidden inline elements |
lib/commons/text/remove-unicode.js | Extends options to support whitespace removal |
lib/commons/text/native-text-alternative.js | Adds context flag to ignore native text alternatives |
lib/checks/label/label-content-name-mismatch-evaluate.js | Implements advanced text comparison with stemming and cosine similarity |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
<< Describe the changes >>
Closes: