Skip to content

Release 5.16.1 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sajalg-bstack wants to merge 6 commits into
base: main
Choose a base branch
from
+32 −11
Open

Release 5.16.1 #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
74f679e
Added Error Handler
sajalg-bstack Jan 14, 2026
389078f
Fix EDS event error
sajalg-bstack Jan 14, 2026
aa6d837
Updated constants.js with serializableErrorProps
sajalg-bstack Jan 15, 2026
0036065
Kept comments same for consistency
sajalg-bstack Jan 15, 2026
1d04fca
Merge pull request #183 from browserstack/AXE-2704/fix_perfrmance_tim…
sajalg-bstack Jan 16, 2026
a1daf4b
Merge pull request #184 from browserstack/AXE-2707/fix_constants_error
sajalg-bstack Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/core/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ const definitions = [

const constants = {
helpUrlBase: 'https://dequeuniversity.com/rules/',
// Size of a grid square in pixels
gridSize: 200,
// At a certain point, looping over an array of elements and using .match on them
// is slower than just running querySelectorAll again.
selectorSimilarFilterLimit: 700,
results: [],
resultGroups: [],
Expand All @@ -44,7 +47,15 @@ const constants = {
timeout: 10000
}),
allOrigins: '<unsafe_all_origins>',
sameOrigin: '<same_origin>'
sameOrigin: '<same_origin>',
serializableErrorProps: Object.freeze([
'message',
'stack',
'name',
'code',
'ruleId',
'method'
])
};

definitions.forEach(definition => {
Expand Down
30 changes: 20 additions & 10 deletions lib/core/utils/performance-timer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,27 @@ const performanceTimer = (() => {
* @param {String} endMark String name of mark to end measuring
*/
measure(measureName, startMark, endMark, details = {}) {
if (window.performance && window.performance.measure !== undefined) {
if (Object.keys(details).length > 0) {
const measureOpts = {
detail: details,
start: startMark,
end: endMark
};
window.performance.measure(measureName, measureOpts);
} else {
window.performance.measure(measureName, startMark, endMark);
try {
if (window.performance && window.performance.measure !== undefined) {
if (Object.keys(details).length > 0) {
const measureOpts = {
detail: details,
start: startMark,
end: endMark
};
window.performance.measure(measureName, measureOpts);
} else {
window.performance.measure(measureName, startMark, endMark);
}
}
} catch (err) {
// NOTE: Performance metrics will be missed if an error occurs here
a11yEngine.errorHandler.addNonCheckError(
'INSTRUMENTATION_ERROR',
'AxeCore PerformanceTimer measure Error',
err,
true
);
}
},
/**
Expand Down