-
Notifications
You must be signed in to change notification settings - Fork 2
Release 3.0.0 #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 3.0.0 #98
Changes from 4 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8ca2d2d
added changes for build process
SwarajGK 01d91e9
:robot: Automated formatting fixes
SwarajGK 80bf267
Updated axe-core files for 200% zoom
mattscepter aceb5cd
Adressed issue
mattscepter ace6841
Adressed issue
mattscepter 9fa53cb
Merge branch 'main' of github.com:browserstack/a11y-engine-axe-core i…
mattscepter 19077ec
Adressed issue
mattscepter 7bc9186
Adressed issue
mattscepter 05e2ce4
Merge branch 'main' of github.com:browserstack/a11y-engine-axe-core i…
SwarajGK f1c08a4
Merge branch 'dom-forge-build-changes' of github.com:browserstack/a11…
SwarajGK 49c223f
Reverted to cache method
mattscepter 6950c10
Reverted to cache method
mattscepter 6a26aa6
Added fix in getCellFromPoint in create-grid.js for 200% zoom
mattscepter 0b61ea2
Merge branch 'dom-forge-build-changes' of github.com:browserstack/a11…
SwarajGK 5cd4a1f
Updated rule name
mattscepter 6b98646
Added safety to a11yEngineErrors
chikara1608 77cf978
Merge remote-tracking branch 'origin/release-3.0.0' into AXE-570_a11y…
chikara1608 f6d19ff
Merge branch 'main' of github.com:browserstack/a11y-engine-axe-core i…
mattscepter a59be20
Merge branch 'release-3.0.0' into AXE-570_a11yEngineErrors
chikara1608 1f811bf
Merge pull request #103 from browserstack/AXE-570_a11yEngineErrors
ansh21 5610917
Revert "Fix: AXE-570 Fixed a11yEngineErrors being accessed on undefined"
ansh21 a8b0958
Merge pull request #104 from browserstack/revert-103-AXE-570_a11yEngi…
ansh21 3251c8c
Revert "Revert "Fix: AXE-570 Fixed a11yEngineErrors being accessed on…
ansh21 822d241
Merge pull request #105 from browserstack/revert-104-revert-103-AXE-5…
chikara1608 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import cache from '../../core/base/cache'; | ||
import memoize from '../../core/utils/memoize'; | ||
|
||
/** | ||
|
@@ -17,8 +18,18 @@ const getOverflowHiddenAncestors = memoize( | |
|
||
const overflow = vNode.getComputedStylePropertyValue('overflow'); | ||
|
||
if (overflow === 'hidden') { | ||
ancestors.push(vNode); | ||
if (cache.get('200%ZoomRule')) { | ||
|
||
if ( | ||
overflow.includes('hidden') || | ||
overflow.includes('clip') || | ||
overflow.includes('scroll') | ||
) { | ||
ancestors.push(vNode); | ||
} | ||
} else { | ||
if (overflow.includes('hidden')) { | ||
ancestors.push(vNode); | ||
} | ||
} | ||
|
||
return ancestors.concat(getOverflowHiddenAncestors(vNode.parent)); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
import { getNodeFromTree, memoize } from '../../core/utils'; | ||
import { sanitize } from '../text'; | ||
import { getRectCenter, isPointInRect, getIntersectionRect } from '../math'; | ||
import { getIntersectionRect, getRectCenter, isPointInRect } from '../math'; | ||
import getOverflowHiddenAncestors from './get-overflow-hidden-ancestors'; | ||
import cache from '../../core/base/cache'; | ||
|
||
/** | ||
* Get the visible text client rects of a node. | ||
|
@@ -23,13 +24,19 @@ const getVisibleChildTextRects = memoize( | |
} | ||
|
||
const contentRects = getContentRects(textNode); | ||
if (isOutsideNodeBounds(contentRects, nodeRect)) { | ||
if ( | ||
isOutsideNodeBounds(contentRects, nodeRect) && | ||
!cache.get('200%ZoomRule') | ||
) { | ||
return; | ||
} | ||
|
||
clientRects.push(...filterHiddenRects(contentRects, overflowHiddenNodes)); | ||
}); | ||
|
||
if (clientRects.length <= 0 && cache.get('200%ZoomRule')) { | ||
return []; | ||
} | ||
/** | ||
* if all text rects are larger than the bounds of the node, | ||
* or goes outside of the bounds of the node, we need to use | ||
|
@@ -44,6 +51,7 @@ const getVisibleChildTextRects = memoize( | |
* | ||
* @see https://github.com/dequelabs/axe-core/issues/4253 | ||
*/ | ||
|
||
|
||
return clientRects.length | ||
? clientRects | ||
: filterHiddenRects([nodeRect], overflowHiddenNodes); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.