Skip to content

[Typescript] Wrong verbose Options type #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −2
Open

[Typescript] Wrong verbose Options type #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d84e41
fixing verbose types
KevinBon Jul 16, 2020
e56d4b0
adding `true` and `false`
KevinBon Jul 16, 2020
8d870c9
Update README.md
KevinBon Jul 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ To enable verbose logging -
```js
bs_local_args = { 'key': '<browserstack-accesskey>', 'verbose': 'true' }
```
Note - Possible values for 'verbose' modifier are '1', '2', '3' and 'true'
Note - Possible values for 'verbose' modifier are true, false, '1', '2', '3', 'true' and 'false'

#### Folder Testing
To test local folder rather internal server, provide path to folder as value of this option -
Expand Down
4 changes: 3 additions & 1 deletion index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
declare module "browserstack-local" {
type VerboseLevels = boolean | 'true' | 'false' | '1' | '2' | '3'

interface Options {
key: string;
verbose: boolean;
verbose: VerboseLevels;
force: boolean;
only: string;
onlyAutomate: boolean;
Expand Down