Skip to content

Commit cadc0b6

Browse files
fix: fixing failing test cases
1 parent 6449750 commit cadc0b6

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

Access/tests/features/validate_approver_permissions.feature

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,4 @@ Feature: Validate Approver Permission
5454
And Modules does not need secondary approval
5555
When validate_approver_permissions function is called
5656
Then Return value should be permission denied json
57-
5857

Access/tests/test_validate_approver_permission.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -120,19 +120,20 @@ def step_impl(access_mapping):
120120

121121

122122
@given("User who made request has primary approver access")
123-
def step_impl(context, mocker, access_mapping,request_1):
123+
def step_impl(context, mocker, access_mapping, request_1):
124124
"""User who made request has primary approver access."""
125-
mock_permissions = {"approver_permissions": {"1": "ACCESS_APPROVE","2":""}}
125+
mock_permissions = {"approver_permissions": {"1": "ACCESS_APPROVE", "2": ""}}
126126
mocker.patch(
127127
"Access.accessrequest_helper._get_approver_permissions",
128128
return_value=mock_permissions,
129129
)
130130
request_1.user.user.has_permission.return_value = True
131131

132+
132133
@given("User who made request has primary approver access with false response")
133-
def step_impl(context, mocker, access_mapping,request_1):
134+
def step_impl(context, mocker, access_mapping, request_1):
134135
"""User who made request has primary approver access."""
135-
mock_permissions = {"approver_permissions": {"1": "ACCESS_APPROVE","2":""}}
136+
mock_permissions = {"approver_permissions": {"1": "ACCESS_APPROVE", "2": ""}}
136137
mocker.patch(
137138
"Access.accessrequest_helper._get_approver_permissions",
138139
return_value=mock_permissions,
@@ -141,17 +142,18 @@ def step_impl(context, mocker, access_mapping,request_1):
141142

142143

143144
@given("User who made request has secondary approver access")
144-
def step_impl(mocker, context, access_mapping,request_1):
145-
mock_permissions = {"approver_permissions": {"1": "","2": "ACCESS_APPROVE"}}
145+
def step_impl(mocker, context, access_mapping, request_1):
146+
mock_permissions = {"approver_permissions": {"1": "", "2": "ACCESS_APPROVE"}}
146147
mocker.patch(
147148
"Access.accessrequest_helper._get_approver_permissions",
148149
return_value=mock_permissions,
149150
)
150151
request_1.user.user.has_permission.return_value = True
151152

153+
152154
@given("User who made request has only secondary approver access with false response")
153-
def step_impl(mocker, context, access_mapping,request_1):
154-
mock_permissions = {"approver_permissions": {"1": "","2": "ACCESS_APPROVE"}}
155+
def step_impl(mocker, context, access_mapping, request_1):
156+
mock_permissions = {"approver_permissions": {"1": "", "2": "ACCESS_APPROVE"}}
155157
mocker.patch(
156158
"Access.accessrequest_helper._get_approver_permissions",
157159
return_value=mock_permissions,
@@ -161,7 +163,7 @@ def step_impl(mocker, context, access_mapping,request_1):
161163

162164
@given("User who made request not have any approver access")
163165
def step_impl(mocker, request_1):
164-
mock_permissions = {"approver_permissions": {"1":"","2":""}}
166+
mock_permissions = {"approver_permissions": {"1": "", "2": ""}}
165167
mocker.patch(
166168
"Access.accessrequest_helper._get_approver_permissions",
167169
return_value=mock_permissions,

0 commit comments

Comments
 (0)