fix: fixing undefined access grant failed message

Author: vedharish

Access/base_email_access/access.py

@@ -24,8 +24,7 @@ def revoke_owner(self):
 
     # Override in module for specific person who should mark access as revoked
     def access_mark_revoke_permission(self, access_type):
-        # TODO: define ACCESS_REVOKE_PERMISSIONS_MAPPING
-        return ACCESS_REVOKE_PERMISSIONS_MAPPING["security"]
+        return ACCESS_APPROVE_EMAIL
 
     # module's tag() method should return a tag present in
     # hash returned by access_types() "type" key

Access/notifications.py

@@ -72,18 +72,19 @@ def send_membership_accepted_notification(user, group, membership):
     general.emailSES(destination, subject, body)
 
 
-def send_mulitple_membership_accepted_notification(user_names, group, membership):
-    subject = MEMBERSHIP_ACCEPTED_SUBJECT.format(user_names, group.name)
-    body = helpers.generateStringFromTemplate(
-        filename="membershipAcceptedEmailBody.html",
-        user_name=",".join(user_names),
-        group_name=group.name,
-        approver=membership.approver.name,
-    )
-    destination = []
-    destination.append(membership.requested_by.email)
-    destination.append(user_names)
-    general.emailSES(destination, subject, body)
+def send_mulitple_membership_accepted_notification(all_user_emails, group_name, membership):
+    for each_user_email in all_user_emails.keys():
+        subject = MEMBERSHIP_ACCEPTED_SUBJECT.format(each_user_email, group_name)
+        body = helpers.generateStringFromTemplate(
+            filename="membershipAcceptedEmailBody.html",
+            user_name=",".join(each_user_email),
+            group_name=group_name,
+            approver=membership.approver.name,
+        )
+        destination = []
+        destination.append(membership.requested_by.email)
+        destination.append(each_user_email)
+        general.emailSES(destination, subject, body)
 
 
 def generateGroupMemberTable(memberList):

Access/views.py

@@ -251,8 +251,8 @@ def group_access_list(request, group_name):
 
         return render(request, "EnigmaOps/groupAccessList.html", context)
     except Exception as ex:
-        logger.debug(
-            "Error in request not found OR Invalid request type, Error: %s", str(ex)
+        logger.exception(
+            "Error in Group Access List, Error: %s", str(ex)
         )
         json_response = {}
         json_response["error"] = {

templates/EnigmaOps/group_access_list_tabs/users_list_tab.html

@@ -13,6 +13,7 @@
         'form-control',
         'form-control',
         'form-control',
+        'form-control',
         'form-control'
       ]