-
Notifications
You must be signed in to change notification settings - Fork 22
Refactor: Centralize Domain URLs via DOMAINS Object for Improved Configurability #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tech-sushant
wants to merge
5
commits into
browserstack:main
Choose a base branch
from
tech-sushant:central-urls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
174c7d4
feat: refactor API endpoints to use centralized domain constants
tech-sushant db40d5a
removing debugging data
tech-sushant c7d4233
refactor: restore environment-specific logger configuration
tech-sushant 954b9ff
fix: update API endpoints in accessibility and failure logs utilities
tech-sushant b3609e9
Update environment variable names
tech-sushant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
export const DOMAINS = { | ||
API: process.env.API_DOMAIN || "https://api.browserstack.com", | ||
API_CLOUD: | ||
process.env.API_CLOUD_DOMAIN || "https://api-cloud.browserstack.com", | ||
TEST_MANAGEMENT: | ||
process.env.TEST_MGMT_DOMAIN || "https://test-management.browserstack.com", | ||
API_OBSERVABILITY: | ||
process.env.API_OBSERVABILITY_DOMAIN || | ||
"https://api-observability.browserstack.com", | ||
LIVE: process.env.LIVE_DOMAIN || "https://live.browserstack.com", | ||
WWW: process.env.WWW_DOMAIN || "https://www.browserstack.com", | ||
APP_LIVE: process.env.APP_LIVE_DOMAIN || "https://app-live.browserstack.com", | ||
API_ACCESSIBILITY: | ||
process.env.API_ACCESSIBILITY_DOMAIN || | ||
"https://api-accessibility.browserstack.com", | ||
SCANNER: process.env.SCANNER_DOMAIN || "https://scanner.browserstack.com", | ||
} as const; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
export const TCG_TRIGGER_URL = | ||
"https://test-management.browserstack.com/api/v1/integration/tcg/test-generation/suggest-test-cases"; | ||
export const TCG_POLL_URL = | ||
"https://test-management.browserstack.com/api/v1/integration/tcg/test-generation/test-cases-polling"; | ||
export const FETCH_DETAILS_URL = | ||
"https://test-management.browserstack.com/api/v1/integration/tcg/test-generation/fetch-test-case-details"; | ||
import { DOMAINS } from "../../../lib/domains.js"; | ||
|
||
export const TCG_TRIGGER_URL = `${DOMAINS.TEST_MANAGEMENT}/api/v1/integration/tcg/test-generation/suggest-test-cases`; | ||
export const TCG_POLL_URL = `${DOMAINS.TEST_MANAGEMENT}/api/v1/integration/tcg/test-generation/test-cases-polling`; | ||
export const FETCH_DETAILS_URL = `${DOMAINS.TEST_MANAGEMENT}/api/v1/integration/tcg/test-generation/fetch-test-case-details`; | ||
export const FORM_FIELDS_URL = (projectId: string): string => | ||
`https://test-management.browserstack.com/api/v1/projects/${projectId}/form-fields-v2`; | ||
`${DOMAINS.TEST_MANAGEMENT}/api/v1/projects/${projectId}/form-fields-v2`; | ||
export const BULK_CREATE_URL = (projectId: string, folderId: string): string => | ||
`https://test-management.browserstack.com/api/v1/projects/${projectId}/folder/${folderId}/bulk-test-cases`; | ||
`${DOMAINS.TEST_MANAGEMENT}/api/v1/projects/${projectId}/folder/${folderId}/bulk-test-cases`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
BROWSERSTACK_
prefix to all env vars