convert ltx:graphics candidates to file URIs#2367
Draft
xworld21 wants to merge 1 commit intobrucemiller:masterfrom
Draft
convert ltx:graphics candidates to file URIs#2367xworld21 wants to merge 1 commit intobrucemiller:masterfrom
xworld21 wants to merge 1 commit intobrucemiller:masterfrom
Conversation
Owner
|
Interesting; basically you're trying to establish a consistent filename format that avoids OS dependencies. But rather than scattering lots of URI to/from around, and only dealing with |
Contributor
Author
Do you want me to update this? It would be nice to have the issue fixed before 0.8.9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2355 (allegedly) by making
candidatesa comma-separated list of URIs instead of plain file names.I do not have conclusive proof about Windows, because the relevant tests seem to require a minimum texlive version, and I am using MikTeX. This would explain why CI did not catch the issue.
I suggest taking this PR further: make
candidatesa space separated list (since now spaces are %-encoded), and add this restriction to the schema (with something likelist(anyURI)).