Fold 2 calls to kpsewhich; avoid regexp in tightest loop#2514
Merged
brucemiller merged 1 commit intomasterfrom Feb 10, 2025
Merged
Fold 2 calls to kpsewhich; avoid regexp in tightest loop#2514brucemiller merged 1 commit intomasterfrom
brucemiller merged 1 commit intomasterfrom
Conversation
dginev
approved these changes
Feb 10, 2025
Collaborator
dginev
left a comment
dginev
left a comment
There was a problem hiding this comment.
Is substr noticably faster than the regex capture? Curious - by how much?
Looks good to merge.
Owner
Author
|
Maybe by a half for simple cases that easily map to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small optimization to
build_kpse_cache; seemingly worthwhile since it's invoked on every run.