Merged
Conversation
dginev
approved these changes
Mar 21, 2025
| $whatsit->setProperty(depth => Dimension(0)); | ||
| $whatsit->setProperty(pxwidth => $w); | ||
| $whatsit->setProperty(pxheight => $h); | ||
| $whatsit->setProperty(style => "vertical-align:".$base."px") if $base; |
Collaborator
There was a problem hiding this comment.
With a CSS hat on, the vertical-align property would work on inline, inline-block or table-cell display types. Should we explicit enforce the mode that is intended here? I assume it is display: inline; ?
At least that is the default for the SVG display attribute... so that can also be an explicit attribute added in $document->openElement('svg:svg', above.
Mostly worried about cases where something may override that, though I don't have specific examples in mind.
Contributor
There was a problem hiding this comment.
The same would apply to the img tag.
Owner
Author
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
Simply asserting display on the svg wasn't enough for Firefox.
Sheesh. Good to know.
This was referenced Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
baselinekeyword option of pgf. It is basically #2477, but directly implements the baseline adjustment using CSSvertical-align, rather than usurping theimagedepthattribute. All the debugging was done by @xworld21 Thanks!!!Closes #2477