various quality of life attempts for Muscle #59
Draft
starsfordummies wants to merge 15 commits intomasterfrom
Draft
various quality of life attempts for Muscle #59starsfordummies wants to merge 15 commits intomasterfrom
starsfordummies wants to merge 15 commits intomasterfrom
Conversation
Member
|
Great! Have you seen speed-ups with these changes? |
Contributor
Author
|
the only performance gain is with removing the permutedims of #58 - the rest is just helper functions, they don't need to be public or anything but I find that they make programming much less tedious the idea is that if we have two tensors With |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the remove permutedims() PR (#58 ) so finalize that one first
Changes are all in QOL.jl for simplicity, can cherry pick.
Shorthand
*for binary_einsumAdd helper function contract(::Tensor, ::Tensor, inds) to contract tensors over specified indices
More human printing for tensors, instead of printing all values focus on their indices, in my experience works best for debugging algorithms
Various helper functions to make all the rest work