Skip to content

Export normals correctly #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Export normals correctly #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c30da56
Add gp_Dir.Transform to opencascade-sys
gmorenz Jun 8, 2025
1718aa2
Transform normals in meshing
gmorenz Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/opencascade-sys/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,6 +948,8 @@ pub mod ffi {
pub fn gp_OZ() -> &'static gp_Ax1;
pub fn gp_DZ() -> &'static gp_Dir;

pub fn Transform(self: Pin<&mut gp_Dir>, transform: &gp_Trsf);

pub fn X(self: &gp_Dir) -> f64;
pub fn Y(self: &gp_Dir) -> f64;
pub fn Z(self: &gp_Dir) -> f64;
Expand Down
10 changes: 6 additions & 4 deletions crates/opencascade/src/mesh.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ impl Mesher {

let triangulation_handle =
ffi::BRep_Tool_Triangulation(&face.inner, location.pin_mut());
let transform = ffi::TopLoc_Location_Transformation(&location);

let triangulation = ffi::HandlePoly_Triangulation_Get(&triangulation_handle)
.map_err(|_| Error::UntriangulatedFace)?;
Expand All @@ -51,7 +52,7 @@ impl Mesher {

for i in 1..=face_point_count {
let mut point = ffi::Poly_Triangulation_Node(triangulation, i);
point.pin_mut().Transform(&ffi::TopLoc_Location_Transformation(&location));
point.pin_mut().Transform(&transform);
vertices.push(dvec3(point.X(), point.Y(), point.Z()));
}

Expand Down Expand Up @@ -85,15 +86,16 @@ impl Mesher {
}

// Add in the normals.
// TODO(bschwind) - Use `location` to transform the normals.
let normal_array = ffi::TColgp_Array1OfDir_ctor(0, face_point_count);

ffi::compute_normals(&face.inner, &triangulation_handle);

// TODO(bschwind) - Why do we start at 1 here?
for i in 1..(normal_array.Length() as usize) {
let normal = ffi::Poly_Triangulation_Normal(triangulation, i as i32);
normals.push(dvec3(normal.X(), normal.Y(), normal.Z()));
let mut normal = ffi::Poly_Triangulation_Normal(triangulation, i as i32);
normal.pin_mut().Transform(&transform);
let m = if face.orientation() == FaceOrientation::Forward { 1. } else { -1. };
normals.push(dvec3(normal.X() * m, normal.Y() * m, normal.Z() * m));
}

for i in 1..=triangulation.NbTriangles() {
Expand Down