Skip to content

Conversation

@bshelton229
Copy link
Owner

@bshelton229 bshelton229 commented Nov 22, 2024

We ran into a couple obstacles when building our custom AMIs. One was needing to pass a custom instance profile to packer in order to get AWS IAM credentials for pre-pulling some ECR images. The other was wanting to run some custom build scripts after the agent had already been installed.

One of our primary reasons for the custom script after agent installation was to write the ACTIONS_RUNNER_HOOK_JOB_STARTED= environment variable to the /opt/actions-runner/.env file pointing to some cleanup scripts we lay down on disk during AMI building. This may be taken care of if https://github.com/philips-labs/terraform-aws-github-runner/pull/4263 ends up merging, but we have another couple smaller things we're doing to configure the agent installation directory.

I noticed what I think was a missing instance_type override variable in the windows-core-2022 file. I'm not sure if that was an oversight, or if it was omitted for a reason. It's been a long time since I've been proficient in Windows, so I wasn't able to test that part of this very well. Because the windows script seemed to already execute after agent installation, I thought it made sense to have the same input variables for all the profiles, and to just run this script directly after the other custom_shell_script that already exists. I thought it safer to make this additional variable instead of moving the custom_shell_script to after agent installation just in case that caused unforeseen issues for others. That being said, we're only using the custom script after agent installation, so moving the existing script to run after agent installation would also solve our problem.

Thanks so much for this project, this has been immensely beneficial for us.

@bshelton229 bshelton229 changed the title Ami post runner install [Packer] Allow passing in an instance_profile and custom shell scripts that run after the runner installation Nov 22, 2024
@bshelton229 bshelton229 changed the title [Packer] Allow passing in an instance_profile and custom shell scripts that run after the runner installation feat(packer): Allow passing in an instance_profile and custom shell scripts that run after the runner installation Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants