Skip to content

Fix language in README.md #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix language in README.md #6

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e70b65
Fix language in README.md
thodson-usgs Jul 14, 2023
cc93da7
Address review comments
thodson-usgs Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions participants/scipy_018/doc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
Ok so I guess you are reading this cuz you wanna use my code. There are some
functions that do stuf and thats:
The PR_tutorial package contains some simple functions to demonstrate the process of creating and merging a PR request.
Copy link

@ellieLitwack ellieLitwack Jul 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much more professional - thank you for making that change!


One function computes the factorial of a number:

>>> from simple_functions import factorial
>>> factorial(10)
9

and this other part does something. I forget why that I did it:
Another function computes the Fibonacci sequence:

>>> fibonnaccci(100)
Copy link

@ellieLitwack ellieLitwack Jul 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be helpful to know how to import this function.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

[0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89]

If you can't use it, its kind of your problem, not mine!
If you find a bug, please report it on the issue tracker
or submit a pull request with a fix.