Skip to content

Fix package documentation and calculations #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix package documentation and calculations #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c2a794
DOC: Reword narrative documentation
kleavor Jul 14, 2023
de6ad92
Correct buggy_function sexigesimal calculation
kleavor Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions participants/scipy_003/doc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
Ok so I guess you are reading this cuz you wanna use my code. There are some
functions that do stuf and thats:
This is an example of using the functions in this package:

>>> from simple_functions import factorial
>>> factorial(10)
9

and this other part does something. I forget why that I did it:
This is an example of generating a Fibonacci sequence for all values up to some integer:

>>> fibonnaccci(100)
>>> fibonacci(100)
[0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89]

If you can't use it, its kind of your problem, not mine!
2 changes: 1 addition & 1 deletion participants/scipy_003/pr_tutorial/buggy_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def angle_to_sexigesimal(angle_in_degrees, decimals=3):
if math.floor(decimals) != decimals:
raise OSError('decimals should be an integer!')

hours_num = angle_in_degrees*24/180
hours_num = angle_in_degrees*24/360
hours = math.floor(hours_num)

min_num = (hours_num - hours)*60
Expand Down