Skip to content

chore(deps): update dependency webpack-dev-middleware to v5 [security] #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update dependency webpack-dev-middleware to v5 [security] #147

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Aug 6, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Confidence
webpack-dev-middleware 3.6.2 -> 5.3.4 age confidence

GitHub Vulnerability Alerts

CVE-2024-29180

Summary

The webpack-dev-middleware middleware does not validate the supplied URL address sufficiently before returning the local file. It is possible to access any file on the developer's machine.

Details

The middleware can either work with the physical filesystem when reading the files or it can use a virtualized in-memory memfs filesystem.
If writeToDisk configuration option is set to true, the physical filesystem is used:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/setupOutputFileSystem.js#L21

The getFilenameFromUrl method is used to parse URL and build the local file path.
The public path prefix is stripped from the URL, and the unsecaped path suffix is appended to the outputPath:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/getFilenameFromUrl.js#L82
As the URL is not unescaped and normalized automatically before calling the midlleware, it is possible to use %2e and %2f sequences to perform path traversal attack.

PoC

A blank project can be created containing the following configuration file webpack.config.js:
module.exports = { devServer: { devMiddleware: { writeToDisk: true } } };

When started, it is possible to access any local file, e.g. /etc/passwd:
$ curl localhost:8080/public/..%2f..%2f..%2f..%2f../etc/passwd

root:x:0:0:root:/root:/bin/bash
daemon:x:1:1:daemon:/usr/sbin:/usr/sbin/nologin
bin:x:2:2:bin:/bin:/usr/sbin/nologin
sys:x:3:3:sys:/dev:/usr/sbin/nologin
sync:x:4:65534:sync:/bin:/bin/sync
games:x:5:60:games:/usr/games:/usr/sbin/nologin

Impact

The developers using webpack-dev-server or webpack-dev-middleware are affected by the issue. When the project is started, an attacker might access any file on the developer's machine and exfiltrate the content (e.g. password, configuration files, private source code, ...).

If the development server is listening on a public IP address (or 0.0.0.0), an attacker on the local network can access the local files without any interaction from the victim (direct connection to the port).

If the server allows access from third-party domains (CORS, Allow-Access-Origin: * ), an attacker can send a malicious link to the victim. When visited, the client side script can connect to the local server and exfiltrate the local files.

Recommendation

The URL should be unescaped and normalized before any further processing.

Release Notes

webpack/webpack-dev-middleware (webpack-dev-middleware)

v5.3.4

Compare Source

5.3.4 (2024-03-20)
Bug Fixes

v5.3.3

Compare Source

⚠ BREAKING CHANGES
  • minimum supported webpack version is 5.0.0
  • minimum supported Nodejs version is 14.15.0
5.3.3 (2022-05-18)
Bug Fixes
5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes

v5.3.2

Compare Source

⚠ BREAKING CHANGES
  • minimum supported webpack version is 5.0.0
  • minimum supported Nodejs version is 14.15.0
5.3.3 (2022-05-18)
Bug Fixes
5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes

v5.3.1

Compare Source

⚠ BREAKING CHANGES
  • minimum supported webpack version is 5.0.0
  • minimum supported Nodejs version is 14.15.0
5.3.3 (2022-05-18)
Bug Fixes
5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes

v5.3.0

Compare Source

⚠ BREAKING CHANGES
  • minimum supported webpack version is 5.0.0
  • minimum supported Nodejs version is 14.15.0
5.3.3 (2022-05-18)
Bug Fixes
5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes

v5.2.2

Compare Source

Features
5.2.2 (2021-11-17)
Chore
  • update schema-utils package to 4.0.0 version
5.2.1 (2021-09-25)
  • internal release, no visible changes and features

v5.2.1

Compare Source

Features
5.2.2 (2021-11-17)
Chore
  • update schema-utils package to 4.0.0 version
5.2.1 (2021-09-25)
  • internal release, no visible changes and features

v5.2.0

Compare Source

Features
5.2.2 (2021-11-17)
Chore
  • update schema-utils package to 4.0.0 version
5.2.1 (2021-09-25)
  • internal release, no visible changes and features

v5.1.0

Compare Source

Features
  • don't read full file if Range header is present (e8b21f0)
  • output more information on errors (#​1024) (7df9e44)
Bug Fixes

v5.0.0

Compare Source

⚠ BREAKING CHANGES

v4.3.0

Compare Source

Features
Bug Fixes

v4.2.0

Compare Source

Features

v4.1.0

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v4.0.4

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v4.0.3

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v4.0.2

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v4.0.1

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v4.0.0

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v3.7.3

Compare Source

3.7.3 (2020-12-15)
Bug Fixes

v3.7.2

Compare Source

Bug Fixes
4.0.0-rc.0 (2020-02-19)
Bug Fixes
  • respect output.path and output.publicPath options from the configuration
  • respect the stats option from the configuration
  • respect the watchOptions option from the configuration
  • the writeToDisk option now correctly works in multi-compiler mode
  • the outputFileSystem option now correctly works in multi-compiler mode
  • respect [hash]/[fullhash] in output.path and output.publicPath
  • handle exceptions for filesystem operations
  • the Content-Type header doesn't have charset=utf-8 value for custom MIME types and MIME types which can be non utf-8
Features
  • validate options
  • migrate on the webpack logger
  • migrate on the memfs package
  • improve performance
BREAKING CHANGES
  • minimum supported Node.js version is 10.13.0
  • the default value of the option publicPath is taken from the value of the output.publicPath option from the configuration (webpack.config.js)
  • the stats option was removed, the default value of the stats option is taken from the value of the stats option from the configuration (webpack.config.js)
  • the watchOptions was removed, the default value of the watchOptions option is taken from the value of the watchOptions option from the configuration (webpack.config.js)
  • the Content-Type header doesn't have charset=utf-8 value for custom MIME types and MIME types which can be non utf-8
  • the fs option was renamed to the outputFileSystem option
  • the lazy option was removed without replacement
  • the logger, logLevel and logTime options were removed without replacement. You can setup the level value using { infrastructureLogging: { level: 'warn' } }, please read https://webpack.js.org/configuration/other-options/#infrastructurelogging. You can use the infrastructurelog (infrastructureLog in webpack@5) hook to customize logs. The log property in the middleware context was renamed to logger
  • the mimeTypes option first requires you to specify an extension and then a content-type - { mimeTypes: { phtml: 'text/html' } }
  • the force option from the mimeTypes option was removed without replacement
  • the reporter option was removed without replacement
  • the getFilenameFromUrl method was removed from the API
  • the middleware locals now under res.locals.webpack - use res.locals.webpack.stats for access stats and res.locals.webpack.outputFileSystem to access outputFileSystem
3.7.2 (2019-09-28)
Bug Fixes
3.7.1 (2019-09-03)
Bug Fixes

v3.7.1

Compare Source

Bug Fixes
4.0.0-rc.0 (2020-02-19)
Bug Fixes
  • respect output.path and output.publicPath options from the configuration
  • respect the stats option from the configuration
  • respect the watchOptions option from the configuration
  • the writeToDisk option now correctly works in multi-compiler mode
  • the outputFileSystem option now correctly works in multi-compiler mode
  • respect [hash]/[fullhash] in output.path and output.publicPath
  • handle exceptions for filesystem operations
  • the Content-Type header doesn't have charset=utf-8 value for custom MIME types and MIME types which can be non utf-8
Features
  • validate options
  • migrate on the webpack logger
  • migrate on the memfs package
  • improve performance
BREAKING CHANGES
  • minimum supported Node.js version is 10.13.0
  • the default value of the option publicPath is taken from the value of the output.publicPath option from the configuration (webpack.config.js)
  • the stats option was removed, the default value of the stats option is taken from the value of the stats option from the configuration (webpack.config.js)
  • the watchOptions was removed, the default value of the watchOptions option is taken from the value of the watchOptions option from the configuration (webpack.config.js)
  • the Content-Type header doesn't have charset=utf-8 value for custom MIME types and MIME types which can be non utf-8
  • the fs option was renamed to the outputFileSystem option
  • the lazy option was removed without replacement
  • the logger, logLevel and logTime options were removed without replacement. You can setup the level value using { infrastructureLogging: { level: 'warn' } }, please read https://webpack.js.org/configuration/other-options/#infrastructurelogging. You can use the infrastructurelog (infrastructureLog in webpack@5) hook to customize logs. The log property in the middleware context was renamed to logger
  • the mimeTypes option first requires you to specify an extension and then a content-type - { mimeTypes: { phtml: 'text/html' } }
  • the force option from the mimeTypes option was removed without replacement
  • the reporter option was removed without replacement
  • the getFilenameFromUrl method was removed from the API
  • the middleware locals now under res.locals.webpack - use res.locals.webpack.stats for access stats and res.locals.webpack.outputFileSystem to access outputFileSystem
3.7.2 (2019-09-28)
Bug Fixes
3.7.1 (2019-09-03)
Bug Fixes

v3.7.0

Compare Source

Bug Fixes
4.0.0-rc.0 (2020-02-19)
Bug Fixes
  • respect output.path and output.publicPath options from the configuration
  • respect the stats option from the configuration
  • respect the watchOptions option from the configuration
  • the writeToDisk option now correctly works in multi-compiler mode
  • the outputFileSystem option now correctly works in multi-compiler mode
  • respect [hash]/[fullhash] in output.path and output.publicPath
  • handle exceptions for filesystem operations
  • the Content-Type header doesn't have charset=utf-8 value for custom MIME types and MIME types which can be non utf-8
Features
  • validate options
  • migrate on the webpack logger
  • migrate on the memfs package
  • improve performance
BREAKING CHANGES
  • minimum supported Node.js version is 10.13.0
  • the default value of the option publicPath is taken from the value of the output.publicPath option from the configuration (webpack.config.js)
  • the stats option was removed, the default value of the stats option is taken from the value of the stats option from the configuration (webpack.config.js)
  • the watchOptions was removed, the default value of the watchOptions option is taken from the value of the watchOptions option from the configuration (webpack.config.js)
  • the Content-Type header doesn't have charset=utf-8 value for custom MIME types and MIME types which can be non utf-8
  • the fs option was renamed to the outputFileSystem option
  • the lazy option was removed without replacement
  • the logger, logLevel and logTime options were removed without replacement. You can setup the level value using { infrastructureLogging: { level: 'warn' } }, please read https://webpack.js.org/configuration/other-options/#infrastructurelogging. You can use the infrastructurelog (infrastructureLog in webpack@5) hook to customize logs. The log property in the middleware context was renamed to logger
  • the mimeTypes option first requires you to specify an extension and then a content-type - { mimeTypes: { phtml: 'text/html' } }
  • the force option from the mimeTypes option was removed without replacement
  • the reporter option was removed without replacement
  • the getFilenameFromUrl method was removed from the API
  • the middleware locals now under res.locals.webpack - use res.locals.webpack.stats for access stats and res.locals.webpack.outputFileSystem to access outputFileSystem
3.7.2 (2019-09-28)
Bug Fixes
3.7.1 (2019-09-03)
Bug Fixes

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot changed the title chore(deps): update dependency webpack-dev-middleware to v5 [security] chore(deps): update dependency webpack-dev-middleware to v5 [security] - autoclosed Dec 8, 2024
@renovate renovate bot closed this Dec 8, 2024
@renovate renovate bot deleted the renovate/npm-webpack-dev-middleware-vulnerability branch December 8, 2024 18:37
@renovate renovate bot changed the title chore(deps): update dependency webpack-dev-middleware to v5 [security] - autoclosed chore(deps): update dependency webpack-dev-middleware to v5 [security] Dec 8, 2024
@renovate renovate bot reopened this Dec 8, 2024
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from d593d57 to 150a084 Compare December 8, 2024 22:02
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 150a084 to df9804e Compare August 10, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants