Add DEBUG logging to broadcast path, use parent logger in embedded mode#39
Merged
Add DEBUG logging to broadcast path, use parent logger in embedded mode#39
Conversation
- Add DEBUG-level logs throughout SubmitTransaction: entry, duplicate detection, broadcast start, per-endpoint response, completion - WARN for broadcast timeouts and unexpected status codes - Initialize() now uses the parent logger when provided instead of creating its own, enabling per-module log level control from the host application. Falls back to config-based logger for standalone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initialize()now uses the parent logger when provided instead of creating its own, enabling per-module log level control from the host application (e.g., 1sat-stack'sNewComponentLoggerwith level override). Falls back to config-based logger for standalone mode.Why
When debugging broadcast failures (transactions stuck in RECEIVED status, invalid merkle paths, etc.), there was zero visibility into what happened during the submission flow. These logs are all DEBUG level so they don't impact production — operators set
arcade.log_level: debugonly when diagnosing issues.The logger passthrough fixes a disconnect where the host application configured a debug-level logger for the arcade component, but
Initialize()discarded it and created its own INFO-level logger.Test plan
go build ./...passes