Remove .reverse() from RecentActions now that wallet-toolbox returns DESC order #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Remove .reverse() from RecentActions now that wallet-toolbox returns DESC order
Description:
Summary
.reverse()call in RecentActions componentProblem
RecentActions.tsx was calling
.reverse()to compensate for wallet-toolbox returningtransactions in ASC order. This worked when all transactions fit on one page (<10),
but with pagination it still showed old transactions because page 0 contained the
oldest 10 regardless of the reverse.
Solution
Remove the
.reverse()call. This PR depends on bsv-blockchain/wallet-toolbox/pull/101 whichfixes wallet-toolbox to return DESC order by default.
Files Changed
src/lib/components/RecentActions.tsx- lines 41-42Before/After
Dependencies
Requires bsv-blockchain/wallet-toolbox/pull/101