Conversation
Pre-allocate the byte slice with capacity based on ot to reduce allocations when appending the magic bytes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What Changed
github-tokeninput parameter to thesetup-go-with-cacheaction with description "GitHub token for private module authentication (only used when GOPRIVATE is set in environment)"github-tokeninput is provided andGOPRIVATEenvironment variable is setgit config --global urland automatically setsGONOSUMDBto matchGOPRIVATEif not already setparse-envaction to useENV_JSONenvironment variable instead of direct input reference in the shell commandWhy It Was Necessary
parse-envactionTesting Performed
github-tokenandGOPRIVATEare providedgithub-tokenorGOPRIVATEis missingGONOSUMDBis correctly set when not explicitly definedImpact / Risk
github-tokeninput is optional with an empty string default