Skip to content

[Sync] Update project files from source repository (9def984)#97

Merged
mrz1836 merged 2 commits intomasterfrom
chore/sync-files-bsv-blockchain-forks-20260309-113511-9def984
Mar 9, 2026
Merged

[Sync] Update project files from source repository (9def984)#97
mrz1836 merged 2 commits intomasterfrom
chore/sync-files-bsv-blockchain-forks-20260309-113511-9def984

Conversation

@mrz1836
Copy link
Copy Markdown
Collaborator

@mrz1836 mrz1836 commented Mar 9, 2026

What Changed

  • Added a new github-token input parameter to the setup-go-with-cache action with description "GitHub token for private module authentication (only used when GOPRIVATE is set in environment)"
  • Added a new step "🔐 Configure private module authentication" that conditionally runs when both github-token input is provided and GOPRIVATE environment variable is set
  • The new step configures git to use token-based authentication for GitHub HTTPS URLs via git config --global url and automatically sets GONOSUMDB to match GOPRIVATE if not already set
  • Updated parse-env action to use ENV_JSON environment variable instead of direct input reference in the shell command

Why It Was Necessary

  • To enable GitHub Actions workflows to authenticate and download private Go modules from GitHub repositories
  • To provide a secure, conditional mechanism for private module access that only activates when explicitly needed (both token and GOPRIVATE are present)
  • To improve the security and maintainability of environment variable parsing in the parse-env action

Testing Performed

  • Verify the action runs successfully when both github-token and GOPRIVATE are provided
  • Verify the step is skipped when either github-token or GOPRIVATE is missing
  • Validate that GONOSUMDB is correctly set when not explicitly defined
  • Test that git authentication allows access to private Go modules during build processes

Impact / Risk

  • Breaking Change: None - the new github-token input is optional with an empty string default
  • Risk: Low - the authentication configuration only applies when explicitly enabled via inputs and environment variables
  • Security: Improves private module handling by providing a standard, secure authentication pattern for workflows

@mrz1836 mrz1836 self-assigned this Mar 9, 2026
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Mar 9, 2026
@github-actions github-actions bot added size/M Medium change (51–200 lines) update General updates labels Mar 9, 2026
Pre-allocate the byte slice with capacity based on ot to reduce allocations when appending the magic bytes.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 9, 2026

@mrz1836 mrz1836 merged commit 0dc63ef into master Mar 9, 2026
44 checks passed
@github-actions github-actions bot deleted the chore/sync-files-bsv-blockchain-forks-20260309-113511-9def984 branch March 9, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/M Medium change (51–200 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant