Conversation
Disabled cache warming to prevent OOM kills on GitHub Actions runners and added a build strategy to skip unnecessary Mage-X steps, reducing build time and resource usage.
Removed unnecessary transaction ID and locking script creation for clarity. Updated payload structure to reflect production usage.
Updated tests to utilize real PushDrop scripts and BEEF transactions, simplifying the test setup and improving accuracy.
Updated import statements for clarity and added error handling for BEEF parsing in PushDrop processing. Improved output index validation to prevent out-of-range errors.
github-actions
bot
added
bug-P3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to use Go 1.26.x and upgrades several dependencies, while also simplifying and modernizing the example code for the SHIP API. The changes improve compatibility, keep the project current with upstream libraries, and streamline example usage for developers.
Dependency and environment upgrades:
.github/env/90-project.env,go.mod, and documentation, ensuring builds and tests use the latest supported Go version. [1] [2] [3]github.com/bsv-blockchain/go-overlay-servicesto v1.3.0 andgithub.com/bsv-blockchain/go-wallet-toolboxto v0.178.2, along with numerous indirect dependencies, ensuring compatibility and access to new features and bug fixes. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Build and workflow improvements:
MAGE_X_BUILD_STRATEGY=skipto the environment to optionally skip unnecessary Mage-X build steps, reducing CI build time and resource usage.Example and code simplification:
examples/ship/main.goby removing the custom sample script and outpoint construction, instead focusing on the minimal structure required for theOutputAdmittedByTopicAPI, making it easier for developers to understand and adapt.