Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.github/.env.basefile (550 lines) containing all GoFortress configuration defaults.github/env/*.envfiles organized by concern:00-core.env- Go version and module configuration10-coverage.env- Coverage tool configuration10-mage-x.env- MAGE-X task runner configuration10-pre-commit.env- Pre-commit hook configuration10-security.env- Security scanning configuration20-redis.env- Redis service configuration20-workflows.env- GitHub workflow settings.github/env/load-env.shscript to source environment files in correct order.github/env/README.mddocumenting the new modular environment system.github/actions/load-env/action.ymlto use the newload-env.shscript instead of direct.env.baseloading.github/.yamlfmtfor YAML formatting standards.github/docs/workflows.mdand.github/docs/repository-features.mdto reflect modular configuration approachWhy It Was Necessary
.env.basefile was difficult to navigate, maintain, and understand which settings belonged to which toolsTesting Performed
.github/env/directory structureload-env.shscript implements proper precedence (numbered files, then.env.customoverrides)load-envactionImpact / Risk
.env.basemust migrate to the new modular structure or create.env.customwith their previous overridesload-env.shscript maintains backward compatibility by supporting.env.customoverrides.env.customfiles to ensure compatibility with the new modular structure