Fix multi node test

[sugh01]

No description provided.

[github-actions]

🤖 Claude Code Review

Status: Complete

---

Critical Issues Found:

1. daemon/daemon_stores.go:34 - Using url.URL as map key will cause equality issues. URLs contain pointers/slices internally, so identical URL strings may not match as map keys, leading to cache misses and multiple store instances.

2. test/sequentialtest/double_spend/10_fork_pruning_double_spend_test.go:140 - Logic error: Comment says "Delete txB" but code deletes txA. This changes the test behavior - appears txB should be deleted since it is on the losing chain.

Design Concerns:

3. daemon/test_daemon.go:258 - Creating temporary settings.Settings to extract P2P port is fragile. The override function may expect a fully initialized object or have side effects.

4. daemon/test_daemon.go:168 - Commented-out code for unique test contexts may impact test isolation. Without unique contexts, concurrent TestDaemons could share cached listeners causing port conflicts.

Other Changes:

• Settings configuration refactored to use KAFKA_SUFFIX pattern (cleaner)
• Blockchain store now supports multiple URLs via caching (once map key issue is fixed)
• New fork pruning tests added for postgres/aerospike
• Various test helper function names capitalized for export

[github-actions]

Using url.URL as a map key is problematic. URLs are structs with pointers and slices internally, which means two URLs with identical string representations may not be equal as map keys. This could lead to cache misses where the same URL creates multiple store instances.

Consider using the URL string representation as the map key instead:

mainBlockchainStoreCache map[string]blockchainstore.Store
// Then use: blockchainStoreURL.String() as the key

[github-actions]

This code creates a temporary settings.Settings struct just to extract the P2P port from the override function. This is fragile because:

1. The temporary settings will not have the full configuration context
2. The override function may expect a properly initialized settings object
3. If the override function has side effects or checks other fields, this could fail silently

Consider either:

• Calling the override function after all port assignments
• Adding the P2P port to TestOptions as an explicit field
• Documenting that SettingsOverrideFunc should set P2P.Port and reading it after the override is applied to the real appSettings

[github-actions]

The comment on line 30 says "Delete txB" but the code deletes txA. This appears to be a critical logic error.

At this point in the test:

• txA is on the winning chain (4a)
• txB is on the losing chain (4b)
• The test comment says "Delete txB from UTXO store"

But the code deletes txA instead. This fundamentally changes what the test validates. Based on the scenario description (simulating pruning before a reorg), it seems txB should be deleted, not txA.

[github-actions]

These commented-out lines that modify appSettings.Context appear to be important for test isolation. The comment explains they ensure unique listeners for each TestDaemon instance.

Without this code, multiple TestDaemons running concurrently might share cached listeners from util.GetListener, potentially causing port conflicts or cross-test interference.

Was this intentionally removed? If so, how is test isolation now ensured?