Changed @ngrx/store peer dependency version to >=4.0.0.#32
Open
magnusbakken wants to merge 4 commits intobtroncone:masterfrom
Open
Changed @ngrx/store peer dependency version to >=4.0.0.#32magnusbakken wants to merge 4 commits intobtroncone:masterfrom
magnusbakken wants to merge 4 commits intobtroncone:masterfrom
Conversation
Owner
|
Makes sense, thanks! |
Owner
|
I’m getting merge conflicts, can you update? Thanks! |
Author
|
Ngrx 7 should be right around the corner now. Have you had time to look at this? |
|
Friendly ping @btroncone |
|
Another friendly ping @btroncone, it's been working fine for me on 11.1.1! |
|
Any idea when this change is likely to be merged in and published? |
|
Also looking for this to get merged if possible. |
srhlv
approved these changes
Jun 29, 2022
|
Temporary workaround, add this to package.json: "overrides": {
"ngrx-store-logger": {
"@ngrx/store": ">=4.0.0"
}
} |
Contributor
|
any chance of merging this? |
|
Is this change going to be merged anytime soon? |
|
Could you please merge this? @btroncone |
Contributor
|
We've been updating our fork if you want to use that https://github.com/zeropsio/ngrx-store-logger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since ngrx-store-logger uses so little of the NgRx API, I think it's best to allow arbitrary future versions.