Skip to content

Changed @ngrx/store peer dependency version to >=4.0.0.#32

Open
magnusbakken wants to merge 4 commits intobtroncone:masterfrom
magnusbakken:master
Open

Changed @ngrx/store peer dependency version to >=4.0.0.#32
magnusbakken wants to merge 4 commits intobtroncone:masterfrom
magnusbakken:master

Conversation

@magnusbakken
Copy link
Copy Markdown

Since ngrx-store-logger uses so little of the NgRx API, I think it's best to allow arbitrary future versions.

@btroncone
Copy link
Copy Markdown
Owner

Makes sense, thanks!

@btroncone
Copy link
Copy Markdown
Owner

I’m getting merge conflicts, can you update? Thanks!

@magnusbakken
Copy link
Copy Markdown
Author

Ngrx 7 should be right around the corner now. Have you had time to look at this?

@timbru31
Copy link
Copy Markdown

timbru31 commented Apr 8, 2020

Friendly ping @btroncone

@hdlim15
Copy link
Copy Markdown

hdlim15 commented Jul 10, 2021

Another friendly ping @btroncone, it's been working fine for me on 11.1.1!

@DJesseTaylor
Copy link
Copy Markdown

Any idea when this change is likely to be merged in and published?

@mikeomeara1
Copy link
Copy Markdown

Also looking for this to get merged if possible.

@davidstrahm
Copy link
Copy Markdown

Temporary workaround, add this to package.json:

 "overrides": {
        "ngrx-store-logger": {
            "@ngrx/store": ">=4.0.0"
        }
}

@fxck
Copy link
Copy Markdown
Contributor

fxck commented Jan 23, 2023

any chance of merging this?

@PunitaGosar-QHR
Copy link
Copy Markdown

Is this change going to be merged anytime soon?

@endlacer
Copy link
Copy Markdown

endlacer commented Jul 17, 2024

Could you please merge this? @btroncone

@fxck
Copy link
Copy Markdown
Contributor

fxck commented Jul 17, 2024

We've been updating our fork if you want to use that https://github.com/zeropsio/ngrx-store-logger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.