Skip to content

Conversation

@btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Feb 16, 2025

Summary

  • Adding an enum that communicates the websocket connection states
  • Fix typo

Closes #352

@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 77.46479% with 16 lines in your changes missing coverage. Please review.

Project coverage is 87.47%. Comparing base (cdacfc6) to head (fffaaa7).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/kraken/spot/websocket/connectors.py 70.83% 7 Missing ⚠️
src/kraken/futures/websocket/__init__.py 70.00% 6 Missing ⚠️
src/kraken/spot/websocket/__init__.py 82.35% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   87.49%   87.47%   -0.02%     
==========================================
  Files          22       22              
  Lines        1935     1972      +37     
==========================================
+ Hits         1693     1725      +32     
- Misses        242      247       +5     
Flag Coverage Δ
unittests 87.47% <77.46%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/kraken/spot/funding.py 45.83% <ø> (ø)
src/kraken/utils/utils.py 91.30% <100.00%> (+6.68%) ⬆️
src/kraken/spot/websocket/__init__.py 88.88% <82.35%> (-2.03%) ⬇️
src/kraken/futures/websocket/__init__.py 84.61% <70.00%> (+0.22%) ⬆️
src/kraken/spot/websocket/connectors.py 87.15% <70.83%> (+0.09%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@btschwertfeger btschwertfeger merged commit 8b07fd5 into master Mar 14, 2025
42 checks passed
@btschwertfeger btschwertfeger deleted the 352-websocket-error-propagation-lacks-usability branch March 14, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Websocket error propagation lacks usability

1 participant