Skip to content

Fix Error Handling of Call to CertOpenSystemStoreA #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FabianScheidt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Error Handling of Call to CertOpenSystemStoreA #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3ecf91
fix error handling of call to certopensystemstorea
FabianScheidt Oct 21, 2020
6d9feef
bump version to 1.0.1
FabianScheidt Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,12 @@ typedef struct _CERT_CONTEXT {
options.maxcerts = 300;
}

var hStoreHandle = null;
const hStoreHandle = Crypto.CertOpenSystemStoreA(null, StoreName);
var pCertContext = null;
if (hStoreHandle = Crypto.CertOpenSystemStoreA(null, StoreName)){
if (!ref.isNull(hStoreHandle)){
//console.log("The "+StoreName+" store has been opened as ", hStoreHandle);
} else {
console.log("The "+StoreName+" store failed to open.");
return [];
throw new Error('The '+StoreName+' store failed to open.');
}

var maxcerts = options.maxcerts;
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "node-windows-root-certs",
"version": "1.0.0",
"version": "1.0.1",
"description": "Enables read of windows root certificates using ffi, and patching of node to use them",
"main": "index.js",
"scripts": {
Expand Down