Open
Conversation
| } | ||
|
|
||
| func main() { | ||
| var user_input = map[int]string{ // Input from the user for each of the SLI |
Author
There was a problem hiding this comment.
Is your assumption SLI=metric?
| var aggregated_node_load float64 = 7 // The aggregated value from prometheus for node load | ||
| var aggregated_response_time float64 = 7 // The aggregated value from prometheus for response time | ||
|
|
||
| if total_time != new_uptime && len(list_of_uptimes) == 0 && uptime_state == true { // When downtime happens for the first time |
Author
There was a problem hiding this comment.
You mean when we don't have data when we just started with algorithm?
| if total_time != new_uptime && len(list_of_uptimes) == 0 && uptime_state == true { // When downtime happens for the first time | ||
| uptime_state = false | ||
| list_of_uptimes = append(list_of_uptimes, new_uptime) | ||
| } else if list_of_uptimes[n] != new_uptime { // When the uptime begins after a downtime and storing the value of Delta |
Author
There was a problem hiding this comment.
I think, this algorithm could be simplified, with a simple function - getStatusOfApp(AppName)
- Get the current status of app, if it's down, note the time we checked and do a delta between when the app changed status and when we checked last time, if it's down, we already broke the SLA(unless we're checking for part of apps). With this you don't have to maintain, another slice of uptime and downtime_delta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a PR to make sure review is easier.