fix: (azblob) Handle 404 responses gracefully#871
Closed
eplightning wants to merge 1 commit intobuchgr:masterfrom
Closed
fix: (azblob) Handle 404 responses gracefully#871eplightning wants to merge 1 commit intobuchgr:masterfrom
eplightning wants to merge 1 commit intobuchgr:masterfrom
Conversation
mostynb
approved these changes
Nov 14, 2025
Collaborator
mostynb
left a comment
mostynb
left a comment
There was a problem hiding this comment.
lgtm- thanks (I don't have an azure account to test with)
Collaborator
|
Landed this, with a slightly different commit message. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to how its already done in all other proxy backends, Azure Blob proxy backend needs to be able to handle case of missing blob in its
Getmethod.Without this, certain clients break and do not work over gRPC protocol. Example of one such a client is https://github.com/moonrepo/moon , not sure about bazel itself.