Use the X-Forwarded-For address in response logs if set. #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandjitsu
force-pushed
the
master
branch
7 times, most recently
from
26f7162 to
dc3c477
Compare
rolandjitsu
commented
Jan 15, 2026
Collaborator
|
Hi, this looks like two different changes in one PR. Could you drop the container image changes from this PR and create a new PR for that? |
Author
Will do. |
Author
Moved the change to #882. |
mostynb
reviewed
Jan 16, 2026
| if xff := r.Header.Get("X-Forwarded-For"); xff != "" { | ||
| // XFF format: client, proxy1, proxy2 | ||
| parts := strings.Split(xff, ",") | ||
| remoteAddr = strings.TrimSpace(parts[0]) |
Collaborator
There was a problem hiding this comment.
Since this is untrustworthy data, I wonder if we should log it differently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on k8s and using a proxy such as ingress-nginx, the printed host in logs is not the user's IP. This patch will read the
X-Forwarded-Forheader and use that instead of the requestr.RemoteAddrif it's set.